exceptionfactory commented on code in PR #8658:
URL: https://github.com/apache/nifi/pull/8658#discussion_r1571402283
##########
nifi-nar-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java:
##########
@@ -83,6 +112,25 @@ public class ExcelReader extends SchemaRegistryService
implements RecordReaderFa
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor PROTECTED_STRATEGY = new
PropertyDescriptor
+ .Builder().name("Protected Strategy")
+ .displayName("Protected Strategy")
Review Comment:
The wording of `Protected Strategy` does not seem as an intuitive as it
could be when considering some of the [Microsoft documentation on protection
and
security](https://support.microsoft.com/en-us/office/protection-and-security-in-excel-be0b34db-8cb6-44dd-a673-0b3e3475ac2d).
From one angle, this property controls how the Reader will attempt to
process the spreadsheet, so it could be thought of an the `Decryption
Strategy`. From the perspective of the spreadsheet, this might make more sense
as `Protection Type`, being either `Unprotected` or `Password Protected`. What
do you think about `Protection Type` as the name for this property and the
associated `enum`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
