Re: [PR] [NIFI-13056][NIFI-13011] canvas icons, theming, and contrast ratio improvements [nifi]

[via GitHub]

scottyaslan commented on code in PR #8663:
URL: https://github.com/apache/nifi/pull/8663#discussion_r1575045577


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.ts:
##########
@@ -155,9 +155,9 @@ export class ControllerServiceTable {
             return 'invalid fa fa-warning';
         } else {
             if (entity.status.runStatus === 'DISABLED') {
-                return 'disabled primary-color icon icon-enable-false';
+                return 'disabled on-surface-default icon icon-enable-false';

Review Comment:
   ![Screenshot 2024-04-22 at 12 26 07 
PM](https://github.com/apache/nifi/assets/6797571/b1626786-5f09-4a2e-9c7d-f20f808e3084)
   ![Screenshot 2024-04-22 at 12 26 17 
PM](https://github.com/apache/nifi/assets/6797571/4359f706-dfa7-489c-b11d-d35e62b55bde)
   ![Screenshot 2024-04-22 at 12 26 34 
PM](https://github.com/apache/nifi/assets/6797571/a0382194-5cae-4253-9536-79fe46bc867c)
   ![Screenshot 2024-04-22 at 12 27 13 
PM](https://github.com/apache/nifi/assets/6797571/02c74428-924b-4381-8fae-9a7c3504e666)
   ![Screenshot 2024-04-22 at 12 27 36 
PM](https://github.com/apache/nifi/assets/6797571/34dd22e8-2a48-41fd-8cf4-d52e5539adb2)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org