lordgamez commented on code in PR #1765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1765#discussion_r1575801013
##########
docker/test/integration/cluster/containers/MinifiContainer.py:
##########
@@ -177,6 +178,8 @@ def deploy(self):
if self.options.enable_sql:
image = self.image_store.get_image('minifi-cpp-sql')
+ elif self.options.enable_example_minifi_python_processors:
+ image =
self.image_store.get_image('minifi-cpp-with-example-python-processors')
elif
self.options.use_nifi_python_processors_with_system_python_packages_installed:
image =
self.image_store.get_image('minifi-cpp-nifi-python-system-python-packages')
Review Comment:
I think we just didn't have the need for it yet. These added features to the
base minifi image are usually used in separate tests or even separate features,
so we didn't need to combine them. I think it can be refactored in the future
to have a list of required add-ons instead of a single parameter, but that
should be done when one of the tests require it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
