rfellows commented on code in PR #8696:
URL: https://github.com/apache/nifi/pull/8696#discussion_r1578393570
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html:
##########
@@ -25,15 +25,26 @@ <h2 mat-dialog-title>Create New {{ portTypeLabel }}</h2>
</mat-form-field>
@if (!isRootProcessGroup) {
<mat-form-field>
- <mat-label>Receive From</mat-label>
+ <mat-label>
+ {{ ComponentType.InputPort == this.request.type ? 'Receive
From' : 'Send To' }}
Review Comment:
```suggestion
{{ ComponentType.InputPort == request.type ? 'Receive
From' : 'Send To' }}
```
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/disable-controller-service/disable-controller-service.component.html:
##########
@@ -33,11 +33,25 @@ <h2 mat-dialog-title>Disable Controller Service</h2>
</div>
<div class="flex flex-col">
<div>Scope</div>
- <div class="accent-color font-medium">Service
and referencing components</div>
+ <div class="accent-color font-medium">
+ Service and referencing components
+ <i
+ class="fa fa-info-circle"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ tooltipInputData="Referencing
components must be disabled/stopped in order to disable this service."></i>
+ </div>
Review Comment:
This one is weird since the info icon is in the "value" area and not the
label.
<img width="295" alt="Screenshot 2024-04-24 at 3 36 51 PM"
src="https://github.com/apache/nifi/assets/713866/bf0cccad-923a-4461-ae81-b146564443f3">
Thoughts on moving to something like this for this case?
```suggestion
<div>
<span class="accent-color
font-medium">Service and referencing components</span>
<i
class="fa fa-info-circle ml-1"
nifiTooltip
[tooltipComponentType]="TextTip"
tooltipInputData="Referencing
components must be disabled/stopped in order to disable this service."></i>
</div>
```
<img width="274" alt="Screenshot 2024-04-24 at 3 36 23 PM"
src="https://github.com/apache/nifi/assets/713866/f4156d5e-ac41-4586-a3a3-54785db5d8c1">
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/process-group/edit-process-group/edit-process-group.component.html:
##########
@@ -118,7 +123,14 @@ <h2 mat-dialog-title>{{ readonly ? 'Process Group Details'
: 'Edit Process Group
<div class="w-full">
<div>
<mat-form-field>
- <mat-label>Default FlowFile
Expiration</mat-label>
+ <mat-label>
+ Default FlowFile Expiration
+ <i
+ class="fa fa-info-circle"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ tooltipInputData="This setting applies
as the default FLowFile expiration for any new connection. Configuration of
existing connections is unaffected."></i>
Review Comment:
```suggestion
tooltipInputData="This setting
applies as the default FlowFile expiration for any new connection.
Configuration of existing connections is unaffected."></i>
```
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html:
##########
@@ -25,15 +25,26 @@ <h2 mat-dialog-title>Create New {{ portTypeLabel }}</h2>
</mat-form-field>
@if (!isRootProcessGroup) {
<mat-form-field>
- <mat-label>Receive From</mat-label>
+ <mat-label>
+ {{ ComponentType.InputPort == this.request.type ? 'Receive
From' : 'Send To' }}
+ <i
+ class="fa fa-info-circle"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ [tooltipInputData]="
+ ComponentType.InputPort == this.request.type
Review Comment:
```suggestion
ComponentType.InputPort == request.type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]