martinzink commented on code in PR #1769:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1769#discussion_r1579314596


##########
CMakeLists.txt:
##########
@@ -22,7 +22,7 @@ cmake_policy(SET CMP0096 NEW) # policy to preserve the 
leading zeros in PROJECT_
 cmake_policy(SET CMP0065 OLD) # default export policy, required for self-dlopen
 cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted 
contents to the time of extraction
 
-project(nifi-minifi-cpp VERSION 0.15.0)
+project(nifi-minifi-cpp VERSION 1.0.0)

Review Comment:
   We should upgrade the version of libcore aswell.
   
https://github.com/apache/nifi-minifi-cpp/blob/7f37f62f5ef86ed922959b25fb0096a2eac51020/libminifi/CMakeLists.txt#L23



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to