exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2079866019
As the `Pcap` class already includes notable differences from the example, it is worth retaining the link, but also refactoring the code to align it with other project conventions, such as removing the use of `_` as a prefix in variable names. The use of the `ByteBufferInterface` also raises some questions about whether the standard Java `ByteBuffer` could be used. That's on a cursory review, a more detailed evaluation is still necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
