[
https://issues.apache.org/jira/browse/NIFI-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787584#comment-15787584
]
ASF GitHub Bot commented on NIFI-3260:
--------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/1372
As a counterpoint to the idea of putting it in a separate repo, would it be
possible to produce the official image as part of a maven build stage? To
reference an internet URL somewhat breaks the idea that the build system works
of of package names/versions. Both maven and the OS (alpine, centos, etc.)
reference dependencies by name/version only. If we can avoid this, we also
improve portability of the builds and prevent issues when the upstream HTTP url
of the referenced built nifi changes or goes down.
What the others say about the self-referencing version makes sense, too.
Basically, if building the image were another build stage, then the version
of the docker image produced would just be in sync with the source tree as a
whole. E.g. you build a 1.1.0 release, and the java build/package produces a
1.1.0 binary, then the final docker packaging stage produces a 1.1.0 image.
The docker-maven-plugin that @ddewaele references looks like a perfect way
to add this as another maven stage.
> Official Docker Image
> ---------------------
>
> Key: NIFI-3260
> URL: https://issues.apache.org/jira/browse/NIFI-3260
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Reporter: Jeremy Dyer
> Assignee: Jeremy Dyer
>
> This JIRA is for setting up a Docker folder structure within the NiFi source
> code as discussed in the dev mailing list at
> https://lists.apache.org/thread.html/e905a559cb01b30f1a7032cec5c9605685f27a65bdf7fee41b735089@%3Cdev.nifi.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
