[
https://issues.apache.org/jira/browse/NIFI-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787626#comment-15787626
]
ASF GitHub Bot commented on NIFI-3004:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1375
NIFI-3004 Improved StandardSSLContextService customValidate
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1375
----
commit 6131ec888067046209b897303d627f2aa5fb3835
Author: Pierre Villard <pierre.villard...@gmail.com>
Date: 2016-12-30T11:37:04Z
NIFI-3004 Improved StandardSSLContextService customValidate
----
> Improve StandardSSLContextService customValidate
> ------------------------------------------------
>
> Key: NIFI-3004
> URL: https://issues.apache.org/jira/browse/NIFI-3004
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Michael Moser
> Priority: Minor
> Labels: newbie
>
> The StandardSSLContextService customValidate() method can be called many
> times in one validation cycle, so it must be efficient. Currently, it calls
> validateStore() on keystore and truststore, which opens each file and
> verifies it can be read and the password is correct. If that works then it
> calls verifySslConfig() which creates 3 sample SSLContext objects.
> Improve this by remembering when customValidate() has been successful and
> avoiding doing another full validation either for a very small amount of time
> or until one of the Property values changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
