turcsanyip commented on PR #8617:
URL: https://github.com/apache/nifi/pull/8617#issuecomment-2094368629

   @exceptionfactory I managed to fix the tests by changing the logic in 
FetchSmb.
   
   There were 2 overlapping sessions to the SMB server: one for reading the 
file and the other for executing the completions strategy (move or delete) in 
`commitAsync()`. I moved the commit out of the TWR block of the first session, 
so the "read" session gets closed before the "move/delete" session starts.
   
   Parallel sessions should not cause issues as the file handles are closed 
properly and it worked in my environments (ran flows connecting to Windows 
share and Samba share, ran integrations tests on Mac and Linux). Not sure what 
the docker environment is doing in Github CI but this change fixed it. I re-ran 
the integrations tests 3 times and all were green.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to