lordgamez commented on code in PR #1773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1773#discussion_r1590785907
##########
bootstrap/system_dependency.py:
##########
@@ -36,7 +36,7 @@ def _create_system_dependencies(minifi_options:
MinifiOptions) -> Dict[str, Set[
system_dependencies['libpng'] = {'libpng'}
if minifi_options.is_enabled("ENABLE_GPS"):
system_dependencies['gpsd'] = {'gpsd'}
- if minifi_options.is_enabled("ENABLE_COAP"):
+ if minifi_options.is_enabled("ENABLE_COAP") or
(minifi_options.is_enabled("ENABLE_SQL") and platform.system() != "Windows"):
Review Comment:
Good point, updated in 89705cf30c2716920784561647c1f2cbe11726a1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
