james94 commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2112912172
Thanks for your suggestion @szaszm I was considering to break this PR into multiple parts because like you said there is a lot to review. Actually, with each major update and commit hash, my goal was to make it easier to track each section of the new update that I made. For example with just updating **OpenSSL** to have USE_CONAN_PACKAGER support and backward compatibility for USE_CMAKE_FETCH_CONTENT, which impacts **libminifi**, we could reference my current commit hash from **UPDATE (May 4, 2024) - [2d1b884](https://github.com/apache/nifi-minifi-cpp/pull/1775/commits/2d1b8842c6809380f981f9857543805efbfd00cc)** and extract out just the part for OpenSSL, so its a smaller PR following your suggestions. Once its approved, we're on the same page for what you guys are looking for, we could look toward bringing up USE_CONAN_PACKAGER support for building the whole **libminifi** like I do in commit **2d1b884**. I will follow up with a smaller PR for **OpenSSL** impacting part of **libminifi**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
