joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619049108
########## nifi-assembly/pom.xml: ########## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> <version>2.0.0-SNAPSHOT</version> <type>nar</type> </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-generic-db-adapter-provider-nar</artifactId> + <version>2.0.0-SNAPSHOT</version> + <type>nar</type> Review Comment: Can you share more about the benefit of each of these being their own nar? If i understand each nar correctly it does not contain provider specific things like mssql/etc.. So it seems like they can all be together. If something had bespoke requirements splitting them is good. Can you share more on what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org