bbende commented on code in PR #8860:
URL: https://github.com/apache/nifi/pull/8860#discussion_r1620747959
##########
nifi-manifest/nifi-runtime-manifest-core/src/main/java/org/apache/nifi/runtime/manifest/impl/StandardComponentManifestBuilder.java:
##########
@@ -61,6 +65,24 @@ public ComponentManifestBuilder addReportingTask(final
ReportingTaskDefinition r
return this;
}
+ @Override
+ public ComponentManifestBuilder
addParameterProvider(ParameterProviderDefinition parameterProviderDefinition) {
+ if (parameterProviderDefinition == null) {
+ throw new IllegalArgumentException("Parameter Provider definition
cannot be null");
+ }
+ parameterProviders.add(parameterProviderDefinition);
+ return this;
+ }
+
+ @Override
+ public ComponentManifestBuilder
addFlowAnalysisRule(FlowAnalysisRuleDefinition flowAnalysisRuleDefinition) {
+ if (flowAnalysisRuleDefinition == null) {
+ throw new IllegalArgumentException("Flow Analysis Rule definition
cannot be null");
+ }
+ flowAnalysisRules.add(flowAnalysisRuleDefinition);
+ return this;
+ }
+
Review Comment:
There is still one change needed here in the final `build` method, it needs
to set the parameter providers and flow analysis rules from the builder into
the final `ComponentManifest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
