rfellows commented on code in PR #8918:
URL: https://github.com/apache/nifi/pull/8918#discussion_r1626237881


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/src/app/ui/common/navigation/navigation.component.scss:
##########
@@ -30,7 +29,6 @@
     }
 
     a {
-        font-size: 12px;

Review Comment:
   removing this and not adding a corresponding `text-sm` in the dom makes the 
log out link font larger (14px) than it was prior.
   before:
   <img width="214" alt="Screenshot 2024-06-04 at 11 37 47 AM" 
src="https://github.com/apache/nifi/assets/713866/87d93dca-aac1-4580-a2e0-d95e0ebb0874";>
   
   with this change:
   <img width="220" alt="Screenshot 2024-06-04 at 11 37 34 AM" 
src="https://github.com/apache/nifi/assets/713866/caa41178-dc8d-4561-bc19-cc8a6504d5ec";>
   
   Could probably add `text-sm` to the div that wraps both the username and log 
out link elements to solve both of these.



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/apps/nifi/src/app/ui/common/navigation/navigation.component.scss:
##########
@@ -21,7 +21,6 @@
     }
 
     .current-user {
-        font-size: 12px;

Review Comment:
   removing this and not adding a corresponding `text-sm` in the dom makes the 
username font larger (14px) than it was prior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to