lhotari commented on code in PR #38:
URL: https://github.com/apache/nifi-maven/pull/38#discussion_r1627645025
##########
pom.xml:
##########
@@ -71,32 +71,28 @@
<url>https://issues.apache.org/jira/browse/NIFI</url>
</issueManagement>
<properties>
- <!-- Set minimum Java version for maven-enforcer-plugin from parent
POM -->
- <minimalJavaBuildVersion>1.8.0-251</minimalJavaBuildVersion>
- <!-- Set minimum Maven version for maven-enforcer-plugin from parent
POM -->
- <minimalMavenBuildVersion>3.6.3</minimalMavenBuildVersion>
- <maven.compiler.source>1.8</maven.compiler.source>
- <maven.compiler.target>1.8</maven.compiler.target>
+ <maven.compiler.release>21</maven.compiler.release>
Review Comment:
> Isn't staying on the latest 1.x version of the plugin an option?
We'd like to use `skipDocGeneration` added by
https://github.com/apache/nifi-maven/pull/35. There's no 1.x release of the
plugin that includes that. More context in
https://github.com/apache/nifi-maven/pull/35#issuecomment-2116764510 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
