fgerlits opened a new pull request, #1817: URL: https://github.com/apache/nifi-minifi-cpp/pull/1817
If the source or build directories contained whitespace, CMake could not generate the `agent_version.cpp` file because the call to `generateVersion.bat` failed. The two path parameters simply had to be quoted, but CMake calls the COMMAND directly without stripping `""`s, so I had to use PowerShell to convert the path to a short path (which looks like `C:\Users\JaneDo~1\src\minifi`). I have also added more verbose logging to make it easier to diagnose issues which may arise in the future. https://issues.apache.org/jira/browse/MINIFICPP-2343 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
