exceptionfactory commented on code in PR #9059:
URL: https://github.com/apache/nifi/pull/9059#discussion_r1667599755
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/BundleUpdateStrategy.java:
##########
@@ -22,11 +22,7 @@ public enum BundleUpdateStrategy {
/**
* If a proposed flow has a different bundle than the current flow, the
bundle is not updated
*/
- IGNORE_BUNDLE,
Review Comment:
This could be valid in some circumstances and should be reverted.
##########
nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/admin/service/entity/ConfigureDetailsEntity.java:
##########
@@ -20,8 +20,6 @@
* Enumeration of Action Configure Details properties stored as Entity objects
*/
public enum ConfigureDetailsEntity implements EntityProperty {
- ACTION("action"),
-
Review Comment:
This is valid and should be reverted.
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/index/lucene/CommitPreference.java:
##########
@@ -19,6 +19,5 @@
public enum CommitPreference {
FORCE_COMMIT,
- PREVENT_COMMIT,
- NO_PREFERENCE;
+ PREVENT_COMMIT;
Review Comment:
It looks like this could be valid, and should be reverted.
##########
nifi-framework-api/src/main/java/org/apache/nifi/cluster/ConnectionState.java:
##########
@@ -24,41 +24,6 @@ public enum ConnectionState {
*/
NOT_CLUSTERED,
- /**
- * Instance is in the process of connecting to the cluster
- */
- CONNECTING,
-
- /**
- * Instance is connected to the cluster
- */
- CONNECTED,
-
- /**
- * Instance is in the process of disconnecting from the cluster
- */
- DISCONNECTING,
-
- /**
- * Instance is disconnected from the cluster
- */
- DISCONNECTED,
-
- /**
- * Instance is offloading
- */
- OFFLOADING,
-
- /**
- * Instances has completed offloading
- */
- OFFLOADED,
-
- /**
- * Instance has been removed from the cluster
- */
- REMOVED,
-
Review Comment:
This looks valid and seems like it should be reverted.
##########
nifi-extension-bundles/nifi-pgp-bundle/nifi-pgp-processors/src/main/java/org/apache/nifi/processors/pgp/attributes/CompressionAlgorithm.java:
##########
@@ -26,8 +26,6 @@ public enum CompressionAlgorithm {
ZIP(CompressionAlgorithmTags.ZIP),
- ZLIB(CompressionAlgorithmTags.ZLIB),
-
Review Comment:
This is a valid option and the change should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]