mark-bathori commented on PR #9061: URL: https://github.com/apache/nifi/pull/9061#issuecomment-2230834458
Thanks @pgyori for the review. I think that it is a good approach to offer the same functionality both in Python and Java side, however I feel it is unnecessary to add methods that are currently unused. Over time we can further extend the Python side with additional methods when new functionalities will require them. - Renaming 'getProperties()' to 'getAllProperties()' wouldn't be good because they have different return type in Java side - At this point I would also avoid code duplication, since both contexts use the same approach for 'getProperties()' and 'newPropertyValue()' so I would keep it as it is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
