exceptionfactory commented on code in PR #9119:
URL: https://github.com/apache/nifi/pull/9119#discussion_r1695238982
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java:
##########
@@ -264,46 +261,28 @@ public class DebugFlow extends AbstractProcessor {
public Set<Relationship> getRelationships() {
synchronized (relationships) {
if (relationships.get() == null) {
- HashSet<Relationship> relSet = new HashSet<>();
- relSet.add(REL_SUCCESS);
- relSet.add(REL_FAILURE);
- relationships.compareAndSet(null,
Collections.unmodifiableSet(relSet));
+ relationships.compareAndSet(null, Set.of(REL_SUCCESS,
REL_FAILURE));
}
return relationships.get();
}
}
@Override
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
- synchronized (propertyDescriptors) {
- if (propertyDescriptors.get() == null) {
- ArrayList<PropertyDescriptor> propList = new ArrayList<>();
- propList.add(FF_SUCCESS_ITERATIONS);
- propList.add(FF_FAILURE_ITERATIONS);
- propList.add(FF_ROLLBACK_ITERATIONS);
- propList.add(FF_ROLLBACK_YIELD_ITERATIONS);
- propList.add(FF_ROLLBACK_PENALTY_ITERATIONS);
- propList.add(FF_EXCEPTION_ITERATIONS);
- propList.add(FF_EXCEPTION_CLASS);
- propList.add(NO_FF_SKIP_ITERATIONS);
- propList.add(NO_FF_EXCEPTION_ITERATIONS);
- propList.add(NO_FF_YIELD_ITERATIONS);
- propList.add(NO_FF_EXCEPTION_CLASS);
- propList.add(WRITE_ITERATIONS);
- propList.add(CONTENT_SIZE);
- propList.add(ON_SCHEDULED_SLEEP_TIME);
- propList.add(ON_SCHEDULED_FAIL);
- propList.add(ON_UNSCHEDULED_SLEEP_TIME);
- propList.add(ON_UNSCHEDULED_FAIL);
- propList.add(ON_STOPPED_SLEEP_TIME);
- propList.add(ON_STOPPED_FAIL);
- propList.add(ON_TRIGGER_SLEEP_TIME);
- propList.add(CUSTOM_VALIDATE_SLEEP_TIME);
- propList.add(IGNORE_INTERRUPTS);
-
- propertyDescriptors.compareAndSet(null,
Collections.unmodifiableList(propList));
+ synchronized (properties) {
+ if (properties.get() == null) {
+ List<PropertyDescriptor> properties = List.of(
+ FF_SUCCESS_ITERATIONS, FF_FAILURE_ITERATIONS,
FF_ROLLBACK_ITERATIONS, FF_ROLLBACK_YIELD_ITERATIONS,
+ FF_ROLLBACK_PENALTY_ITERATIONS,
FF_EXCEPTION_ITERATIONS, FF_EXCEPTION_CLASS, NO_FF_SKIP_ITERATIONS,
+ NO_FF_EXCEPTION_ITERATIONS, NO_FF_YIELD_ITERATIONS,
NO_FF_EXCEPTION_CLASS, WRITE_ITERATIONS,
+ CONTENT_SIZE, ON_SCHEDULED_SLEEP_TIME,
ON_SCHEDULED_FAIL, ON_UNSCHEDULED_SLEEP_TIME,
+ ON_UNSCHEDULED_FAIL, ON_STOPPED_SLEEP_TIME,
ON_STOPPED_FAIL, ON_TRIGGER_SLEEP_TIME,
+ CUSTOM_VALIDATE_SLEEP_TIME, IGNORE_INTERRUPTS
Review Comment:
For readability and maintenance, it would be helpful to have one property
per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DeduplicateRecord.java:
##########
@@ -266,8 +264,10 @@ public class DeduplicateRecord extends AbstractProcessor {
.required(false)
.build();
-
- // RELATIONSHIPS
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ DEDUPLICATION_STRATEGY, DISTRIBUTED_MAP_CACHE, CACHE_IDENTIFIER,
PUT_CACHE_IDENTIFIER, RECORD_READER, RECORD_WRITER,
+ INCLUDE_ZERO_RECORD_FLOWFILES, RECORD_HASHING_ALGORITHM,
FILTER_TYPE, FILTER_CAPACITY_HINT, BLOOM_FILTER_FPP
Review Comment:
Please format with one property descriptor per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java:
##########
@@ -286,32 +284,12 @@ public class ExecuteStreamCommand extends
AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
- private static final List<PropertyDescriptor> PROPERTIES;
- private static final String MASKED_ARGUMENT = "********";
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ WORKING_DIR, EXECUTION_COMMAND, ARGUMENTS_STRATEGY,
EXECUTION_ARGUMENTS, ARG_DELIMITER,
+ IGNORE_STDIN, PUT_OUTPUT_IN_ATTRIBUTE, PUT_ATTRIBUTE_MAX_LENGTH,
MIME_TYPE
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQLRecord.java:
##########
@@ -153,27 +150,12 @@ public class ExecuteSQLRecord extends AbstractExecuteSQL {
.build();
public ExecuteSQLRecord() {
- final Set<Relationship> r = new HashSet<>();
- r.add(REL_SUCCESS);
- r.add(REL_FAILURE);
- relationships = Collections.unmodifiableSet(r);
-
- final List<PropertyDescriptor> pds = new ArrayList<>();
- pds.add(DBCP_SERVICE);
- pds.add(SQL_PRE_QUERY);
- pds.add(SQL_SELECT_QUERY);
- pds.add(SQL_POST_QUERY);
- pds.add(QUERY_TIMEOUT);
- pds.add(RECORD_WRITER_FACTORY);
- pds.add(NORMALIZE_NAMES);
- pds.add(USE_AVRO_LOGICAL_TYPES);
- pds.add(DEFAULT_PRECISION);
- pds.add(DEFAULT_SCALE);
- pds.add(MAX_ROWS_PER_FLOW_FILE);
- pds.add(OUTPUT_BATCH_SIZE);
- pds.add(FETCH_SIZE);
- pds.add(AUTO_COMMIT);
- propDescriptors = Collections.unmodifiableList(pds);
+ relationships = Set.of(REL_SUCCESS, REL_FAILURE);
+ propDescriptors = List.of(
+ DBCP_SERVICE, SQL_PRE_QUERY, SQL_SELECT_QUERY, SQL_POST_QUERY,
QUERY_TIMEOUT,
+ RECORD_WRITER_FACTORY, NORMALIZE_NAMES, USE_AVRO_LOGICAL_TYPES,
+ DEFAULT_PRECISION, DEFAULT_SCALE, MAX_ROWS_PER_FLOW_FILE,
OUTPUT_BATCH_SIZE, FETCH_SIZE, AUTO_COMMIT
+ );
Review Comment:
These property descriptor and relationship declarations can be moved to
static variables.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java:
##########
@@ -172,24 +171,11 @@ public class GenerateTableFetch extends
AbstractDatabaseFetchProcessor {
.build();
public GenerateTableFetch() {
- final Set<Relationship> r = new HashSet<>();
- r.add(REL_SUCCESS);
- r.add(REL_FAILURE);
- relationships = Collections.unmodifiableSet(r);
-
- final List<PropertyDescriptor> pds = new ArrayList<>();
- pds.add(DBCP_SERVICE);
- pds.add(DB_TYPE);
- pds.add(TABLE_NAME);
- pds.add(COLUMN_NAMES);
- pds.add(MAX_VALUE_COLUMN_NAMES);
- pds.add(QUERY_TIMEOUT);
- pds.add(PARTITION_SIZE);
- pds.add(COLUMN_FOR_VALUE_PARTITIONING);
- pds.add(WHERE_CLAUSE);
- pds.add(CUSTOM_ORDERBY_COLUMN);
- pds.add(OUTPUT_EMPTY_FLOWFILE_ON_ZERO_RESULTS);
- propDescriptors = Collections.unmodifiableList(pds);
+ propDescriptors = List.of(
Review Comment:
This can be moved to a static variable.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchSFTP.java:
##########
@@ -83,48 +84,33 @@
)
public class FetchSFTP extends FetchFileTransfer {
+ private static final PropertyDescriptor PORT =
+ new
PropertyDescriptor.Builder().fromPropertyDescriptor(UNDEFAULTED_PORT).defaultValue("22").build();
+
+ private static final PropertyDescriptor DISABLE_DIRECTORY_LISTING = new
PropertyDescriptor.Builder()
+ .fromPropertyDescriptor(SFTPTransfer.DISABLE_DIRECTORY_LISTING)
+ .description(String.format("Control how '%s' is created when '%s'
is '%s' and '%s' is enabled. %s",
+ MOVE_DESTINATION_DIR.getDisplayName(),
+ COMPLETION_STRATEGY.getDisplayName(),
+ COMPLETION_MOVE.getDisplayName(),
+ MOVE_CREATE_DIRECTORY.getDisplayName(),
+
SFTPTransfer.DISABLE_DIRECTORY_LISTING.getDescription())).build();
+
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ HOSTNAME, PORT, USERNAME, SFTPTransfer.PASSWORD,
SFTPTransfer.PRIVATE_KEY_PATH,
+ SFTPTransfer.PRIVATE_KEY_PASSPHRASE, REMOTE_FILENAME,
COMPLETION_STRATEGY, MOVE_DESTINATION_DIR,
+ MOVE_CREATE_DIRECTORY, DISABLE_DIRECTORY_LISTING,
SFTPTransfer.CONNECTION_TIMEOUT,
+ SFTPTransfer.DATA_TIMEOUT, SFTPTransfer.USE_KEEPALIVE_ON_TIMEOUT,
SFTPTransfer.HOST_KEY_FILE,
+ SFTPTransfer.STRICT_HOST_KEY_CHECKING,
SFTPTransfer.USE_COMPRESSION, SFTPTransfer.PROXY_CONFIGURATION_SERVICE,
+ FTPTransfer.PROXY_TYPE, FTPTransfer.PROXY_HOST,
FTPTransfer.PROXY_PORT, FTPTransfer.HTTP_PROXY_USERNAME,
+ FTPTransfer.HTTP_PROXY_PASSWORD, FILE_NOT_FOUND_LOG_LEVEL,
SFTPTransfer.CIPHERS_ALLOWED,
+ SFTPTransfer.KEY_ALGORITHMS_ALLOWED,
SFTPTransfer.KEY_EXCHANGE_ALGORITHMS_ALLOWED,
+ SFTPTransfer.MESSAGE_AUTHENTICATION_CODES_ALLOWED
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetSFTP.java:
##########
@@ -56,50 +54,23 @@
@SeeAlso(PutSFTP.class)
public class GetSFTP extends GetFileTransfer {
- private List<PropertyDescriptor> properties;
-
- @Override
- protected void init(final ProcessorInitializationContext context) {
- final List<PropertyDescriptor> properties = new ArrayList<>();
- properties.add(SFTPTransfer.HOSTNAME);
- properties.add(SFTPTransfer.PORT);
- properties.add(SFTPTransfer.USERNAME);
- properties.add(SFTPTransfer.PASSWORD);
- properties.add(SFTPTransfer.PRIVATE_KEY_PATH);
- properties.add(SFTPTransfer.PRIVATE_KEY_PASSPHRASE);
- properties.add(SFTPTransfer.REMOTE_PATH);
- properties.add(SFTPTransfer.FILE_FILTER_REGEX);
- properties.add(SFTPTransfer.PATH_FILTER_REGEX);
- properties.add(SFTPTransfer.POLLING_INTERVAL);
- properties.add(SFTPTransfer.RECURSIVE_SEARCH);
- properties.add(SFTPTransfer.FOLLOW_SYMLINK);
- properties.add(SFTPTransfer.IGNORE_DOTTED_FILES);
- properties.add(SFTPTransfer.DELETE_ORIGINAL);
- properties.add(SFTPTransfer.CONNECTION_TIMEOUT);
- properties.add(SFTPTransfer.DATA_TIMEOUT);
- properties.add(SFTPTransfer.HOST_KEY_FILE);
- properties.add(SFTPTransfer.MAX_SELECTS);
- properties.add(SFTPTransfer.REMOTE_POLL_BATCH_SIZE);
- properties.add(SFTPTransfer.STRICT_HOST_KEY_CHECKING);
- properties.add(SFTPTransfer.USE_KEEPALIVE_ON_TIMEOUT);
- properties.add(SFTPTransfer.USE_COMPRESSION);
- properties.add(SFTPTransfer.USE_NATURAL_ORDERING);
- properties.add(SFTPTransfer.PROXY_CONFIGURATION_SERVICE);
- properties.add(FTPTransfer.PROXY_TYPE);
- properties.add(FTPTransfer.PROXY_HOST);
- properties.add(FTPTransfer.PROXY_PORT);
- properties.add(FTPTransfer.HTTP_PROXY_USERNAME);
- properties.add(FTPTransfer.HTTP_PROXY_PASSWORD);
- properties.add(SFTPTransfer.CIPHERS_ALLOWED);
- properties.add(SFTPTransfer.KEY_ALGORITHMS_ALLOWED);
- properties.add(SFTPTransfer.KEY_EXCHANGE_ALGORITHMS_ALLOWED);
- properties.add(SFTPTransfer.MESSAGE_AUTHENTICATION_CODES_ALLOWED);
- this.properties = Collections.unmodifiableList(properties);
- }
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ SFTPTransfer.HOSTNAME, SFTPTransfer.PORT, SFTPTransfer.USERNAME,
SFTPTransfer.PASSWORD,
+ SFTPTransfer.PRIVATE_KEY_PATH,
SFTPTransfer.PRIVATE_KEY_PASSPHRASE, SFTPTransfer.REMOTE_PATH,
+ SFTPTransfer.FILE_FILTER_REGEX, SFTPTransfer.PATH_FILTER_REGEX,
SFTPTransfer.POLLING_INTERVAL,
+ SFTPTransfer.RECURSIVE_SEARCH, SFTPTransfer.FOLLOW_SYMLINK,
SFTPTransfer.IGNORE_DOTTED_FILES,
+ SFTPTransfer.DELETE_ORIGINAL, SFTPTransfer.CONNECTION_TIMEOUT,
SFTPTransfer.DATA_TIMEOUT,
+ SFTPTransfer.HOST_KEY_FILE, SFTPTransfer.MAX_SELECTS,
SFTPTransfer.REMOTE_POLL_BATCH_SIZE,
+ SFTPTransfer.STRICT_HOST_KEY_CHECKING,
SFTPTransfer.USE_KEEPALIVE_ON_TIMEOUT, SFTPTransfer.USE_COMPRESSION,
+ SFTPTransfer.USE_NATURAL_ORDERING,
SFTPTransfer.PROXY_CONFIGURATION_SERVICE, FTPTransfer.PROXY_TYPE,
+ FTPTransfer.PROXY_HOST, FTPTransfer.PROXY_PORT,
FTPTransfer.HTTP_PROXY_USERNAME,
+ FTPTransfer.HTTP_PROXY_PASSWORD, SFTPTransfer.CIPHERS_ALLOWED,
SFTPTransfer.KEY_ALGORITHMS_ALLOWED,
+ SFTPTransfer.KEY_EXCHANGE_ALGORITHMS_ALLOWED,
SFTPTransfer.MESSAGE_AUTHENTICATION_CODES_ALLOWED
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java:
##########
@@ -134,13 +131,15 @@ public class IdentifyMimeType extends AbstractProcessor {
.dependsOn(CONFIG_STRATEGY, REPLACE, MERGE)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES =
+ List.of(USE_FILENAME_IN_DETECTION, CONFIG_STRATEGY,
MIME_CONFIG_BODY, MIME_CONFIG_FILE);
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DetectDuplicate.java:
##########
@@ -111,6 +108,10 @@ public class DetectDuplicate extends AbstractProcessor {
.defaultValue("true")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ CACHE_ENTRY_IDENTIFIER, FLOWFILE_DESCRIPTION, AGE_OFF_DURATION,
DISTRIBUTED_CACHE_SERVICE, CACHE_IDENTIFIER
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java:
##########
@@ -147,27 +143,12 @@ public class ExecuteSQL extends AbstractExecuteSQL {
.build();
public ExecuteSQL() {
- final Set<Relationship> r = new HashSet<>();
- r.add(REL_SUCCESS);
- r.add(REL_FAILURE);
- relationships = Collections.unmodifiableSet(r);
-
- final List<PropertyDescriptor> pds = new ArrayList<>();
- pds.add(DBCP_SERVICE);
- pds.add(SQL_PRE_QUERY);
- pds.add(SQL_SELECT_QUERY);
- pds.add(SQL_POST_QUERY);
- pds.add(QUERY_TIMEOUT);
- pds.add(NORMALIZE_NAMES_FOR_AVRO);
- pds.add(USE_AVRO_LOGICAL_TYPES);
- pds.add(COMPRESSION_FORMAT);
- pds.add(DEFAULT_PRECISION);
- pds.add(DEFAULT_SCALE);
- pds.add(MAX_ROWS_PER_FLOW_FILE);
- pds.add(OUTPUT_BATCH_SIZE);
- pds.add(FETCH_SIZE);
- pds.add(AUTO_COMMIT);
- propDescriptors = Collections.unmodifiableList(pds);
+ relationships = Set.of(REL_SUCCESS, REL_FAILURE);
+ propDescriptors = List.of(
+ DBCP_SERVICE, SQL_PRE_QUERY, SQL_SELECT_QUERY, SQL_POST_QUERY,
QUERY_TIMEOUT,
+ NORMALIZE_NAMES_FOR_AVRO, USE_AVRO_LOGICAL_TYPES,
COMPRESSION_FORMAT,
+ DEFAULT_PRECISION, DEFAULT_SCALE, MAX_ROWS_PER_FLOW_FILE,
OUTPUT_BATCH_SIZE, FETCH_SIZE, AUTO_COMMIT
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java:
##########
@@ -151,6 +149,10 @@ public class EvaluateXQuery extends AbstractProcessor {
.defaultValue("false")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ DESTINATION, XML_OUTPUT_METHOD, XML_OUTPUT_OMIT_XML_DECLARATION,
XML_OUTPUT_INDENT, VALIDATE_DTD
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java:
##########
@@ -156,11 +155,17 @@ public class ExecuteProcess extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ COMMAND, COMMAND_ARGUMENTS, BATCH_DURATION, REDIRECT_ERROR_STREAM,
WORKING_DIR, ARG_DELIMITER, MIME_TYPE
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateJsonPath.java:
##########
@@ -126,6 +124,10 @@ public class EvaluateJsonPath extends
AbstractJsonPathProcessor {
.dependsOn(DESTINATION, DESTINATION_ATTRIBUTE)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ DESTINATION, RETURN_TYPE, PATH_NOT_FOUND,
NULL_VALUE_DEFAULT_REPRESENTATION, MAX_STRING_LENGTH
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java:
##########
@@ -156,6 +154,11 @@ public class ExtractGrok extends AbstractProcessor {
.defaultValue("false")
.build();
+ private final static List<PropertyDescriptor> PROPERTIES = List.of(
+ GROK_EXPRESSION, GROK_PATTERNS, DESTINATION, CHARACTER_SET,
+ MAX_BUFFER_SIZE, NAMED_CAPTURES_ONLY, KEEP_EMPTY_CAPTURES
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractText.java:
##########
@@ -231,6 +231,12 @@ must be named, if the number of groups (not including
capture group 0) does not
.defaultValue("false")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ CHARACTER_SET, MAX_BUFFER_SIZE, MAX_CAPTURE_GROUP_LENGTH,
CANON_EQ, CASE_INSENSITIVE, COMMENTS, DOTALL,
+ LITERAL, MULTILINE, UNICODE_CASE, UNICODE_CHARACTER_CLASS,
UNIX_LINES, INCLUDE_CAPTURE_GROUP_ZERO,
+ ENABLE_REPEATING_CAPTURE_GROUP, ENABLE_NAMED_GROUPS
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchFile.java:
##########
@@ -177,6 +176,11 @@ public class FetchFile extends AbstractProcessor {
.required(true)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ FILENAME, COMPLETION_STRATEGY, MOVE_DESTINATION_DIR,
CONFLICT_STRATEGY,
+ FILE_NOT_FOUND_LOG_LEVEL, PERM_DENIED_LOG_LEVEL
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchFile.java:
##########
@@ -195,26 +199,17 @@ public class FetchFile extends AbstractProcessor {
"Any FlowFile that could not be fetched from the file system for
any reason other than insufficient permissions or the file not existing will be
transferred to this Relationship.")
.build();
+ private static final Set<Relationship> RELATIONSHIPS =
+ Set.of(REL_SUCCESS, REL_NOT_FOUND, REL_PERMISSION_DENIED,
REL_FAILURE);
Review Comment:
Please reformat with one relationship per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchDistributedMapCache.java:
##########
@@ -121,6 +119,11 @@ public class FetchDistributedMapCache extends
AbstractProcessor {
.defaultValue("UTF-8")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ PROP_CACHE_ENTRY_IDENTIFIER, PROP_DISTRIBUTED_CACHE_SERVICE,
PROP_PUT_CACHE_VALUE_IN_ATTRIBUTE,
+ PROP_PUT_ATTRIBUTE_MAX_LENGTH, PROP_CHARACTER_SET
Review Comment:
Recommend removing the `PROP_` prefix from each descriptor.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FetchDistributedMapCache.java:
##########
@@ -121,6 +119,11 @@ public class FetchDistributedMapCache extends
AbstractProcessor {
.defaultValue("UTF-8")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ PROP_CACHE_ENTRY_IDENTIFIER, PROP_DISTRIBUTED_CACHE_SERVICE,
PROP_PUT_CACHE_VALUE_IN_ATTRIBUTE,
+ PROP_PUT_ATTRIBUTE_MAX_LENGTH, PROP_CHARACTER_SET
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ForkRecord.java:
##########
@@ -142,6 +141,9 @@ public class ForkRecord extends AbstractProcessor {
.required(true)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES =
+ List.of(RECORD_READER, RECORD_WRITER, MODE, INCLUDE_PARENT_FIELDS);
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateFlowFile.java:
##########
@@ -132,35 +129,20 @@ public class GenerateFlowFile extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES =
+ List.of(FILE_SIZE, BATCH_SIZE, DATA_FORMAT, UNIQUE_FLOWFILES,
CUSTOM_TEXT, CHARSET, MIME_TYPE);
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java:
##########
@@ -162,6 +158,9 @@ public class FlattenJson extends AbstractProcessor {
.expressionLanguageSupported(ExpressionLanguageScope.NONE)
.build();
+ private static final List<PropertyDescriptor> PROPERTIES =
+ List.of(SEPARATOR, FLATTEN_MODE, IGNORE_RESERVED_CHARACTERS,
RETURN_TYPE, CHARACTER_SET, PRETTY_PRINT);
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFile.java:
##########
@@ -190,6 +188,11 @@ public class GetFile extends AbstractProcessor {
.defaultValue("10")
.build();
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ DIRECTORY, FILE_FILTER, PATH_FILTER, BATCH_SIZE, KEEP_SOURCE_FILE,
RECURSE, POLLING_INTERVAL,
+ IGNORE_HIDDEN_FILES, MIN_AGE, MAX_AGE, MIN_SIZE, MAX_SIZE
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java:
##########
@@ -312,37 +311,20 @@ public class HandleHttpRequest extends AbstractProcessor {
.addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
.defaultValue("512 KB")
.build();
+
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ PORT, HOSTNAME, SSL_CONTEXT, HTTP_PROTOCOL_STRATEGY,
HTTP_CONTEXT_MAP, PATH_REGEX, URL_CHARACTER_SET,
+ ALLOW_GET, ALLOW_POST, ALLOW_PUT, ALLOW_DELETE, ALLOW_HEAD,
ALLOW_OPTIONS, MAXIMUM_THREADS,
+ ADDITIONAL_METHODS, CLIENT_AUTH, CONTAINER_QUEUE_SIZE,
MULTIPART_REQUEST_MAX_SIZE,
+ MULTIPART_READ_BUFFER_SIZE, PARAMETERS_TO_ATTRIBUTES
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java:
##########
@@ -172,24 +171,11 @@ public class GenerateTableFetch extends
AbstractDatabaseFetchProcessor {
.build();
public GenerateTableFetch() {
- final Set<Relationship> r = new HashSet<>();
- r.add(REL_SUCCESS);
- r.add(REL_FAILURE);
- relationships = Collections.unmodifiableSet(r);
-
- final List<PropertyDescriptor> pds = new ArrayList<>();
- pds.add(DBCP_SERVICE);
- pds.add(DB_TYPE);
- pds.add(TABLE_NAME);
- pds.add(COLUMN_NAMES);
- pds.add(MAX_VALUE_COLUMN_NAMES);
- pds.add(QUERY_TIMEOUT);
- pds.add(PARTITION_SIZE);
- pds.add(COLUMN_FOR_VALUE_PARTITIONING);
- pds.add(WHERE_CLAUSE);
- pds.add(CUSTOM_ORDERBY_COLUMN);
- pds.add(OUTPUT_EMPTY_FLOWFILE_ON_ZERO_RESULTS);
- propDescriptors = Collections.unmodifiableList(pds);
+ propDescriptors = List.of(
+ DBCP_SERVICE, DB_TYPE, TABLE_NAME, COLUMN_NAMES,
MAX_VALUE_COLUMN_NAMES, QUERY_TIMEOUT, PARTITION_SIZE,
+ COLUMN_FOR_VALUE_PARTITIONING, WHERE_CLAUSE,
CUSTOM_ORDERBY_COLUMN, OUTPUT_EMPTY_FLOWFILE_ON_ZERO_RESULTS
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoinEnrichment.java:
##########
@@ -223,23 +212,18 @@ public class JoinEnrichment extends BinFiles {
"relationship.")
.build();
- private static final Set<Relationship> relationships =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
- REL_JOINED,
- REL_ORIGINAL,
- REL_TIMEOUT,
- REL_FAILURE
- )));
+ private static final Set<Relationship> RELATIONSHIPS = Set.of(REL_JOINED,
REL_ORIGINAL, REL_TIMEOUT, REL_FAILURE);
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetFTP.java:
##########
@@ -57,44 +55,21 @@
@SeeAlso(PutFTP.class)
public class GetFTP extends GetFileTransfer {
- private List<PropertyDescriptor> properties;
-
- @Override
- protected void init(final ProcessorInitializationContext context) {
- final List<PropertyDescriptor> properties = new ArrayList<>();
- properties.add(FTPTransfer.HOSTNAME);
- properties.add(FTPTransfer.PORT);
- properties.add(FTPTransfer.USERNAME);
- properties.add(FTPTransfer.PASSWORD);
- properties.add(FTPTransfer.CONNECTION_MODE);
- properties.add(FTPTransfer.TRANSFER_MODE);
- properties.add(FTPTransfer.REMOTE_PATH);
- properties.add(FTPTransfer.FILE_FILTER_REGEX);
- properties.add(FTPTransfer.PATH_FILTER_REGEX);
- properties.add(FTPTransfer.POLLING_INTERVAL);
- properties.add(FTPTransfer.RECURSIVE_SEARCH);
- properties.add(FTPTransfer.FOLLOW_SYMLINK);
- properties.add(FTPTransfer.IGNORE_DOTTED_FILES);
- properties.add(FTPTransfer.DELETE_ORIGINAL);
- properties.add(FTPTransfer.CONNECTION_TIMEOUT);
- properties.add(FTPTransfer.DATA_TIMEOUT);
- properties.add(FTPTransfer.MAX_SELECTS);
- properties.add(FTPTransfer.REMOTE_POLL_BATCH_SIZE);
- properties.add(FTPTransfer.USE_NATURAL_ORDERING);
- properties.add(FTPTransfer.PROXY_CONFIGURATION_SERVICE);
- properties.add(FTPTransfer.PROXY_TYPE);
- properties.add(FTPTransfer.PROXY_HOST);
- properties.add(FTPTransfer.PROXY_PORT);
- properties.add(FTPTransfer.HTTP_PROXY_USERNAME);
- properties.add(FTPTransfer.HTTP_PROXY_PASSWORD);
- properties.add(FTPTransfer.BUFFER_SIZE);
- properties.add(FTPTransfer.UTF8_ENCODING);
- this.properties = Collections.unmodifiableList(properties);
- }
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ FTPTransfer.HOSTNAME, FTPTransfer.PORT, FTPTransfer.USERNAME,
FTPTransfer.PASSWORD,
+ FTPTransfer.CONNECTION_MODE, FTPTransfer.TRANSFER_MODE,
FTPTransfer.REMOTE_PATH,
+ FTPTransfer.FILE_FILTER_REGEX, FTPTransfer.PATH_FILTER_REGEX,
FTPTransfer.POLLING_INTERVAL,
+ FTPTransfer.RECURSIVE_SEARCH, FTPTransfer.FOLLOW_SYMLINK,
FTPTransfer.IGNORE_DOTTED_FILES,
+ FTPTransfer.DELETE_ORIGINAL, FTPTransfer.CONNECTION_TIMEOUT,
FTPTransfer.DATA_TIMEOUT,
+ FTPTransfer.MAX_SELECTS, FTPTransfer.REMOTE_POLL_BATCH_SIZE,
FTPTransfer.USE_NATURAL_ORDERING,
+ FTPTransfer.PROXY_CONFIGURATION_SERVICE, FTPTransfer.PROXY_TYPE,
FTPTransfer.PROXY_HOST,
+ FTPTransfer.PROXY_PORT, FTPTransfer.HTTP_PROXY_USERNAME,
FTPTransfer.HTTP_PROXY_PASSWORD,
+ FTPTransfer.BUFFER_SIZE, FTPTransfer.UTF8_ENCODING
Review Comment:
Please reformat with one property per line.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoinEnrichment.java:
##########
@@ -189,18 +186,10 @@ public class JoinEnrichment extends BinFiles {
.defaultValue("10000")
.build();
- private static final List<PropertyDescriptor> properties =
Collections.unmodifiableList(Arrays.asList(
- ORIGINAL_RECORD_READER,
- ENRICHMENT_RECORD_READER,
- RECORD_WRITER,
- JOIN_STRATEGY,
- SQL,
- DEFAULT_PRECISION,
- DEFAULT_SCALE,
- INSERTION_RECORD_PATH,
- MAX_BIN_COUNT,
- TIMEOUT
- ));
+ private static final List<PropertyDescriptor> PROPERTIES = List.of(
+ ORIGINAL_RECORD_READER, ENRICHMENT_RECORD_READER, RECORD_WRITER,
JOIN_STRATEGY, SQL, DEFAULT_PRECISION,
+ DEFAULT_SCALE, INSERTION_RECORD_PATH, MAX_BIN_COUNT, TIMEOUT
Review Comment:
Please reformat with one property per line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]