KalmanJantner commented on PR #9136: URL: https://github.com/apache/nifi/pull/9136#issuecomment-2304722350
> Thank you for the pull request. This is really an useful feature, which will provide more insight of the status of the C2 operation when an error happens. > > I left some comments, please check them. Also two general comments: > > * we should also apply this approach for all the the handlers, not just UpdateConfigurationOperationHandler. To use this approach properly, potentially some refactoring will be needed on handler level and below. For example, in UpdateAssetOperation handler the exception is logged, an optional is returned only. We should move away from the optional approach in favor of exception managed approach like in UpdateConfigurationOperationHandler. > * Please squash the commits. Before the final review, there should only be one commit Thanks you for the review. I applied the recommended changes and squashed the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
