simonbence commented on PR #9115:
URL: https://github.com/apache/nifi/pull/9115#issuecomment-2306606535

   Hi @exceptionfactory !
   
   For full disclosure, it looks like there is already an ordering within the 
mapping process: 
[here](https://github.com/apache/nifi/blob/7ade77ac22fc2e5bbd38151e32c96667020f30a8/nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java#L125)
   
   I take a looks of the usages and it seems to me that not all usages of the 
method is based (directly) on the result of the `getMapping` 
([example](https://github.com/apache/nifi/blob/83b701a25ea2820d20768ca4946f5698249beb0a/nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/IdentityAuthenticationProvider.java#L92),
 so I could not safely say that the original ordering is enough.
   
   The question comes however if with this addition we still need the original 
ordering or not. I would not disturb it within this ticket but later on it 
might be a reasonable move to remove that (after considering the possible 
implications)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to