GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1420
NIFI-3216: Add N signals to Wait/Notify
**NOTE** This PR is based on [NIFI-3214: Added fetch and replace to
DistributedMapCache](https://github.com/apache/nifi/pull/1410) which is under
review process. Please review and comment on NIFI-3214 for DistributedCache
implementation. This PR focuses on Wait/Notify processors to provide waiting
mechanism for multiple signals.
- Support counters at Wait/Notify processors so that NiFi flow can be
configured to wait for N signals
- Extract Wait/Notify logics into WaitNotifyProtocol
- Added FragmentAttributes to manage commonly used fragment attributes
- Changed existing split processors to set 'fragment.identifier' and
'fragment.count', so that Wait can use those to wait for all splits get
processed
A NiFi template file for testing this new capability is available in this
[Gist](https://gist.github.com/ijokarumawak/dc81cbfa04bc7ec39e89522653db5ea5).
It contains Process Groups for each updated split processors work with
Wait/Notify processors looks like below:
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3216
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1420
----
commit 42cf830c7101a33c54689afd01a864c961de95be
Author: Koji Kawamura <ijokaruma...@apache.org>
Date: 2017-01-11T06:57:40Z
NIFI-3214: Added fetch and replace to DistributedMapCache
- Using fetch and replace together can provide optimistic locking for
concurrency control.
- Added fetch to get cache entry with its meta data such as revision
number.
- Added replace to update cache only if it has not been updated.
- Added Map Cache protocol version 2 for those new operations.
- Existing operations such as get or put can work with protocol version
1.
commit 05aa3214150a9f2abb712af1e46c5cde70a0322c
Author: Koji Kawamura <ijokaruma...@apache.org>
Date: 2017-01-13T07:52:30Z
NIFI-3216: Add N signals to Wait/Notify
- Support counters at Wait/Notify processors so that NiFi flow can be
configured to wait for N signals
- Extract Wait/Notify logics into WaitNotifyProtocol
- Added FragmentAttributes to manage commonly used fragment attributes
- Changed existing split processors to set 'fragment.identifier' and
'fragment.count', so that Wait can use those to wait for all splits
get processed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
