exceptionfactory commented on code in PR #9512:
URL: https://github.com/apache/nifi/pull/9512#discussion_r1838304946
##########
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/command/CommandOption.java:
##########
@@ -177,6 +177,10 @@ public enum CommandOption {
USERNAME("usr", "username", "The username for authentication when
obtaining an access token", true),
PASSWORD("pwd", "password", "The password for authentication when
obtaining an access token", true),
+ OIDC_URL("oidcurl", "oidcUrl", "The OIDC URL to access the token endpoint
for the OAuth Client Credentials Flow", true),
Review Comment:
Regarding the property naming, it seems like it would be helpful to name
this something like `oidcTokenUrl` to make it clear that this refers to the
`token_endpoint`, not the OpenID Connect discovery configuration JSON. The
description is clear, but making it clear in the property name would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
