bbende commented on code in PR #9607:
URL: https://github.com/apache/nifi/pull/9607#discussion_r1900948464
##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/Kafka3ConnectionService.java:
##########
@@ -146,6 +149,22 @@ public class Kafka3ConnectionService extends
AbstractControllerService implement
)
.build();
+ public static final PropertyDescriptor KERBEROS_CREDENTIALS_SERVICE = new
PropertyDescriptor.Builder()
+ .name("kerberos-credentials-service")
+ .displayName("Kerberos Credentials Service")
+ .description("Service supporting generalized credentials
authentication with Kerberos")
+ .identifiesControllerService(KerberosUserService.class)
+ .required(false)
+ .build();
Review Comment:
It has been a while since I worked on this, but I am not sure the Kafka
processors can use the regular `KerberosUserService` because they expect to get
the JAAS config string from the service and give it to the Kafka client which
does the actual login, and this won't work for some of the implementations of
`KerberosUserService`, this was the reason for limiting it to the
`SelfContainedKerberosUserService`, see comment here:
https://github.com/apache/nifi/blob/main/nifi-extension-bundles/nifi-standard-services/nifi-kerberos-user-service-api/src/main/java/org/apache/nifi/kerberos/SelfContainedKerberosUserService.java#L20-L25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
