exceptionfactory commented on code in PR #9577:
URL: https://github.com/apache/nifi/pull/9577#discussion_r1920679463


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/prometheusutil/NiFiMetricsRegistry.java:
##########
@@ -275,5 +275,35 @@ public NiFiMetricsRegistry() {
                 .help("Provenance repository free space in bytes")
                 .labelNames("instance", "component_type", "component_name", 
"component_id", "parent_id", "repo_identifier")
                 .register(registry));
+
+        nameToGaugeMap.put("PROCESSING_PERF_CPU_MILLIS", Gauge.build()
+                .name("nifi_processing_cpu_duration")
+                .help("Estimated cpu time (in milliseconds) used by this 
component")

Review Comment:
   ```suggestion
                   .help("Estimated CPU time (in milliseconds) used by this 
component")
   ```



##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/prometheusutil/NiFiMetricsRegistry.java:
##########
@@ -275,5 +275,35 @@ public NiFiMetricsRegistry() {
                 .help("Provenance repository free space in bytes")
                 .labelNames("instance", "component_type", "component_name", 
"component_id", "parent_id", "repo_identifier")
                 .register(registry));
+
+        nameToGaugeMap.put("PROCESSING_PERF_CPU_MILLIS", Gauge.build()
+                .name("nifi_processing_cpu_duration")
+                .help("Estimated cpu time (in milliseconds) used by this 
component")
+                .labelNames("instance", "component_type", "component_name", 
"component_id", "parent_id", "repo_identifier")
+                .register(registry));
+
+        nameToGaugeMap.put("PROCESSING_PERF_GC_MILLIS", Gauge.build()
+                .name("nifi_processing_gc_duration")
+                .help("Estimated gc time (in milliseconds) used by this 
component")

Review Comment:
   ```suggestion
                   .help("Estimated garbage collection time (in milliseconds) 
used by this component")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to