tpalfy commented on code in PR #9657:
URL: https://github.com/apache/nifi/pull/9657#discussion_r1925807281
##########
nifi-extension-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/test/java/org/apache/nifi/services/protobuf/schema/TestProtoSchemaParser.java:
##########
@@ -115,4 +118,34 @@ public void testSchemaParserForProto2() {
final RecordSchema actual = schemaParser.createSchema("Proto2Message");
assertEquals(expected, actual);
}
+
+ @Test
+ public void testSchemaParserWithSelfCircularReference() {
+ final ProtoSchemaParser schemaParser = new
ProtoSchemaParser(loadCircularReferenceTestSchema());
+ final RecordSchema recordCSchema = schemaParser.createSchema("C");
+
+ final Optional<RecordField> parentField =
recordCSchema.getField("parent");
+ assertTrue(parentField.isPresent());
+ assertEquals(RecordFieldType.RECORD,
parentField.get().getDataType().getFieldType());
+
+ assertEquals(recordCSchema, ((RecordDataType)
parentField.get().getDataType()).getChildSchema());
+ }
+
+ @Test
+ public void testSchemaParserWithMutualCircularReference() {
+ final ProtoSchemaParser schemaParser = new
ProtoSchemaParser(loadCircularReferenceTestSchema());
+ final RecordSchema recordASchema = schemaParser.createSchema("A");
+
+ final Optional<RecordField> recordAField = recordASchema.getField("b");
+ assertTrue(recordAField.isPresent());
+ assertEquals(RecordFieldType.RECORD,
recordAField.get().getDataType().getFieldType());
+
+ final RecordSchema recordBSchema = ((RecordDataType)
recordAField.get().getDataType()).getChildSchema();
+
+ final Optional<RecordField> recordBField = recordBSchema.getField("a");
+ assertTrue(recordBField.isPresent());
+ assertEquals(RecordFieldType.RECORD,
recordBField.get().getDataType().getFieldType());
+
+ assertEquals(recordBSchema, ((RecordDataType)
recordAField.get().getDataType()).getChildSchema());
Review Comment:
In line 143:
`final RecordSchema recordBSchema = ((RecordDataType)
recordAField.get().getDataType()).getChildSchema();`
So
`assertEquals(recordBSchema, ((RecordDataType)
recordAField.get().getDataType()).getChildSchema());`
is a tautology.
```suggestion
final ProtoSchemaParser schemaParser = new
ProtoSchemaParser(loadCircularReferenceTestSchema());
final RecordSchema recordASchema = schemaParser.createSchema("A");
final Optional<RecordField> bOfA = recordASchema.getField("b");
assertTrue(bOfA.isPresent());
assertEquals(RecordFieldType.RECORD,
bOfA.get().getDataType().getFieldType());
final RecordSchema recordBSchema = schemaParser.createSchema("B");
final Optional<RecordField> aOfB = recordBSchema.getField("a");
assertTrue(aOfB.isPresent());
assertEquals(RecordFieldType.RECORD,
aOfB.get().getDataType().getFieldType());
assertEquals(recordBSchema, ((RecordDataType)
bOfA.get().getDataType()).getChildSchema());
assertEquals(recordASchema, ((RecordDataType)
aOfB.get().getDataType()).getChildSchema());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
