markap14 commented on PR #9668: URL: https://github.com/apache/nifi/pull/9668#issuecomment-2622453626
Hey @dan-s1 thanks for pointing that out. I wasn't aware of that PR. In the future, for a PR like that, which is going to make huge changes and/or change conventions, it is probably best to start with a [DISCUSS] thread on the mailing list to ensure that the right eye balls are on. I do (very much!) appreciate you taking the initiative to consolidate all of that into a single naming convention. The concern that I have is that I'd argue that the proper convention would be propertyDescriptors and relationships, saving all-caps naming conventions for constants. This separation is used throughout the codebase, especially the framework / "engine". But now that you've done the hard work of making things consistent, we can easily change the naming convention with a "find & replace all" should that be decision made, so thanks for that! Given that, I'll go ahead and change this to match the existing pattern of PROPERTY_DESCRIPTORS and RELATIONSHIPS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
