exceptionfactory commented on code in PR #9748:
URL: https://github.com/apache/nifi/pull/9748#discussion_r1970466850
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java:
##########
@@ -531,4 +554,38 @@ protected List<String> getQueries(final String value) {
}
protected abstract SqlWriter configureSqlWriter(ProcessSession session,
ProcessContext context, FlowFile fileToProcess);
+
+ enum ContentOutputStrategy implements DescribedValue {
+ EMPTY_RESULT(
+ "Overwrite Content",
+ "Overwrites the FlowFile content with the empty result set."
+ ),
+ IGNORED(
+ "Ignore Results",
+ "Ignores the result and passes the incoming FlowFile content to
the next processor."
+ );
+
+ private final String value;
+ private final String description;
+
+ ContentOutputStrategy(final String value, final String description) {
+ this.value = value;
Review Comment:
```suggestion
private final String displayName;
private final String description;
ContentOutputStrategy(final String displayName, final String
description) {
this.displayName = displayName;
```
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java:
##########
@@ -531,4 +554,38 @@ protected List<String> getQueries(final String value) {
}
protected abstract SqlWriter configureSqlWriter(ProcessSession session,
ProcessContext context, FlowFile fileToProcess);
+
+ enum ContentOutputStrategy implements DescribedValue {
+ EMPTY_RESULT(
+ "Overwrite Content",
+ "Overwrites the FlowFile content with the empty result set."
+ ),
+ IGNORED(
+ "Ignore Results",
+ "Ignores the result and passes the incoming FlowFile content to
the next processor."
+ );
+
+ private final String value;
+ private final String description;
+
+ ContentOutputStrategy(final String value, final String description) {
+ this.value = value;
+ this.description = description;
+ }
+
+ @Override
+ public String getValue() {
+ return this.value;
Review Comment:
This should use the `name()` method to align with the enum.
```suggestion
return name();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
