pvillard31 commented on code in PR #9792:
URL: https://github.com/apache/nifi/pull/9792#discussion_r1987821814
##########
nifi-extension-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/GetBoxFileCollaborators.java:
##########
@@ -79,6 +80,25 @@ public class GetBoxFileCollaborators extends
AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor ROLES = new
PropertyDescriptor.Builder()
+ .name("Roles")
+ .description("A comma-separated list of collaboration roles to
retrieve. Available roles: editor, viewer, previewer, " +
+ "uploader, previewer uploader, viewer uploader, co-owner,
owner")
+ .required(true)
+ .defaultValue("editor")
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor STATUSES = new
PropertyDescriptor.Builder()
+ .name("Statuses")
+ .description("A comma-separated list of collaboration statuses to
retrieve. Available statuses: accepted, pending, rejected")
+ .required(true)
+ .defaultValue("accepted")
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
Review Comment:
As a follow up of my other comment, can we make those two new properties as
optional with no default value and create the new attributes only if someone
provides a value for those properties?
##########
nifi-extension-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/GetBoxFileCollaborators.java:
##########
@@ -60,10 +61,10 @@
@SeeAlso({FetchBoxFile.class, ListBoxFile.class})
@WritesAttributes({
@WritesAttribute(attribute = ID, description = ID_DESC),
- @WritesAttribute(attribute = "box.collaborations.<status>.users.ids",
description = "Comma-separated list of user collaborator IDs by status"),
- @WritesAttribute(attribute = "box.collaborations.<status>.groups.ids",
description = "Comma-separated list of group collaborator IDs by status"),
- @WritesAttribute(attribute =
"box.collaborations.<status>.users.emails", description = "Comma-separated list
of user collaborator emails by status"),
Review Comment:
So... technically speaking, removing those could be considered as a breaking
change. Unless the RC1 of 2.3.0 is cancelled, this processor is going out with
2.3.0. Can we keep those anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
