exceptionfactory commented on PR #9921: URL: https://github.com/apache/nifi/pull/9921#issuecomment-2859382108
> With the upgrade of geoip2 there is warning message regarding a deprecated method > > ``` > nifi/nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi > -lookup-services/src/main/java/org/apache/nifi/lookup/maxmind/IPLookupService.java:[404,65] [deprecation] getMetroCode() in Location has been deprecated > ``` > > I do not see a suggested replacement in the [source code](https://github.com/maxmind/GeoIP2-java/blob/2c404afadebcdaf7b43dfed0faf68c4b3c6c443d/src/main/java/com/maxmind/geoip2/record/Location.java#L121) I just see > > ``` > /** > * @return The metro code is a no-longer-maintained code for targeting > * advertisements in Google. > * @deprecated Code values are no longer maintained. > */ > ``` > > Do we want to leave the code as is or do we suppress the deprecated message? Based on the message, it sounds like the code should be changed. I think that could be handled in an independent PR to call it out as a change based on the library changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
