[ https://issues.apache.org/jira/browse/NIFI-13467 ]


    Daniel Stieglitz deleted comment on NIFI-13467:
    -----------------------------------------

was (Author: JIRAUSER294662):
I believe there is not much to be done here as the code is following the 
suggestions in the 
[StreamingSheet|https://javadoc.io/static/com.github.pjfanning/excel-streaming-reader/5.0.4/com/github/pjfanning/xlsx/impl/StreamingSheet.html#getPhysicalNumberOfRows%E2%80%93]
 javadoc for method getPhysicalNumberOfRows():

{quote}

Not supported - use 
[{{iterator()}}|https://javadoc.io/static/com.github.pjfanning/excel-streaming-reader/5.0.4/com/github/pjfanning/xlsx/impl/StreamingSheet.html#iterator--]
 or 
[{{rowIterator()}}|https://javadoc.io/static/com.github.pjfanning/excel-streaming-reader/5.0.4/com/github/pjfanning/xlsx/impl/StreamingSheet.html#rowIterator--]
 to iterate over rows and count the rows

{quote}

as it storing a row in a java.util.List and getting the total from the size of 
the list.

> Clarify what the total.rows attribute in SplitExcel Represent
> -------------------------------------------------------------
>
>                 Key: NIFI-13467
>                 URL: https://issues.apache.org/jira/browse/NIFI-13467
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> It was assumed that the SplitExcel total.rows attribute represents total 
> visible rows with data but there are two situations which seem to dispel that 
> assumption. The following two situations must be clarified:
> # The Excel spreadsheet on a particular sheet appears to have *_more rows_* 
> of data than the SplitExcel processor reports with the total.rows attribute
> # The Excel spreadsheet on a particular sheet appears to have *_less rows_* 
> of data than the SplitExcel processor reports with the total.rows attribute



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to