Copilot commented on code in PR #1966:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2096226049
##########
libminifi/include/RemoteProcessGroupPort.h:
##########
@@ -139,14 +134,21 @@ class RemoteProcessorGroupPort : public
core::ProcessorImpl {
void setDirection(sitetosite::TransferDirection direction) {
direction_ = direction;
- if (direction_ == sitetosite::RECEIVE)
- this->setTriggerWhenEmpty(true);
+ if (direction_ == sitetosite::TransferDirection::RECEIVE) {
+ setTriggerWhenEmpty(true);
+ } else {
+ setTriggerWhenEmpty(false);
+ }
}
- void setTimeout(uint64_t timeout) {
+ void setTimeout(std::chrono::milliseconds timeout) {
Review Comment:
Consider updating the function comment to explicitly state that the timeout
is now expected as a duration in milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
