fgerlits commented on code in PR #1963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1963#discussion_r2189342326
##########
extensions/standard-processors/tests/unit/ManifestTests.cpp:
##########
@@ -69,7 +69,7 @@ TEST_CASE("Test Valid Regex", "[validRegex]") {
REQUIRE_FALSE(resp.children.empty());
const auto &processors = resp.children[0];
REQUIRE_FALSE(processors.children.empty());
- const auto &proc_0 = processors.children[0];
+ const auto &proc_0 = "org.apache.nifi.minifi.processors.UpdateAttribute" !=
processors.children[0].name ? processors.children[0] : processors.children[1];
Review Comment:
very minor, but maybe rename this to `update_attribute_processor`?
edit: or is it `not_update_attribute_processor`? what is it that all
processors have except `UpdateAttribute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
