tpalfy commented on PR #10136: URL: https://github.com/apache/nifi/pull/10136#issuecomment-3118526260
Thank you for the feedback @exceptionfactory. As for the `getFlowFileFilter()` without batch size - I'm not sure what the question is about. - The `getFLowFileFilter(batchSize)` will delegate to the `getFlowFileFilter()`. - As far as the explicit call in my implementation - it's only when collecting the invalid FlowFiles. The `Batch Size` property is supposed to be controlling the database side after all. (As per the property's description: "The preferred number of FlowFiles to put to the database in a single transaction"). But more importantly, do I understand correctly, that we shouldn't change the `PutSQL`, but change `DBCPConnectionPoolLookup.getFlowFileFilter()`? (That's what concretely initiated this issue.) How should `DBCPConnectionPoolLookup.getFlowFileFilter()` work in that case? If the FlowFile simply returns a REJECT_AND_CONTINUE, it will still end up staying in the incoming queue indefinitely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
