mcgilman commented on code in PR #10147:
URL: https://github.com/apache/nifi/pull/10147#discussion_r2240711955
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/status-history/status-history.component.html:
##########
@@ -155,8 +180,9 @@ <h2 mat-dialog-title>Status History</h2>
</div>
<div class="chart-panel grow flex
flex-col">
@if (fieldDescriptors$ | async) {
- <div
class="selected-descriptor-container">
- <mat-form-field>
+ <div
class="selected-descriptor-container flex flex-col">
+ <div>Metric</div>
Review Comment:
Thoughts on moving `<div>Metric</div>` to `<mat-label>Metric</mat-label>`
inside the `<mat-form-field>...</mat-form-field>` below?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/status-history/status-history.component.ts:
##########
@@ -175,8 +191,15 @@ export class StatusHistory extends CloseOnEscapeDialog
implements OnInit, AfterV
return s.timestamp;
});
});
- this.minDate = this.nifiCommon.formatDateTime(new
Date(minDate));
- this.maxDate = this.nifiCommon.formatDateTime(new
Date(maxDate));
+ this.formattedMinDate = this.nifiCommon.formatDateTime(new
Date(minDate));
+ this.formattedMaxDate = this.nifiCommon.formatDateTime(new
Date(maxDate));
+
+ this.minDate = minDate;
+ this.maxDate = maxDate;
+ this.updateStartTimeOptions();
+
+ // Initialize filtered instances with all instances
+ this.filteredInstances.set(this.instances);
Review Comment:
Is this needed or does it get called through the call to
`updateStartTimeOptions`?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/status-history/status-history.component.ts:
##########
@@ -67,7 +77,8 @@ import { ContextErrorBanner } from
'../context-error-banner/context-error-banner
NgStyle,
ContextErrorBanner
],
- styleUrls: ['./status-history.component.scss']
+ styleUrls: ['./status-history.component.scss'],
+ standalone: true
Review Comment:
`standalone: true` should be the default and not needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
