lordgamez commented on code in PR #1968:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1968#discussion_r2290489433
##########
thirdparty/couchbase/remove-thirdparty.patch:
##########
@@ -76,7 +60,89 @@ index f02af02..f83c181 100644
"CMAKE_C_VISIBILITY_PRESET hidden"
"CMAKE_CXX_VISIBILITY_PRESET hidden"
"CMAKE_POSITION_INDEPENDENT_CODE ON")
-@@ -159,93 +116,24 @@ if(NOT TARGET taocpp::json)
+ endif()
Review Comment:
The problem is with the reverse patch dry-run that it needs more context if
the patch only contains deletion. In this case the reverse patch dry-run
succeeds and the patch application does not run if we have a smaller context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
