lordgamez commented on code in PR #1965:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1965#discussion_r2303761774
##########
extensions/llamacpp/tests/RunLlamaCppInferenceTests.cpp:
##########
@@ -225,7 +225,7 @@ TEST_CASE("Invalid values for optional double type
properties throw exception")
}
REQUIRE_THROWS_WITH(controller.trigger(minifi::test::InputFlowFileData{.content
= "42", .attributes = {}}),
- fmt::format("Expected parsable float from
RunLlamaCppInference::{}, but got GeneralParsingError (Parsing Error:0)",
property_name));
+ fmt::format("Expected parsable float from \"RunLlamaCppInference::{}\",
but got GeneralParsingError (Parsing Error:0)", property_name));
Review Comment:
This change seems to make the llamacpp test fail after the rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
