exceptionfactory commented on code in PR #10247:
URL: https://github.com/apache/nifi/pull/10247#discussion_r2307544908
##########
nifi-extension-bom/pom.xml:
##########
@@ -213,14 +213,14 @@
</dependency>
<dependency>
<groupId>org.mortbay.jasper</groupId>
- <artifactId>apache-jsp</artifactId>
- <version>10.1.43</version>
+ <artifactId>mortbay-apache-jsp</artifactId>
+ <version>10.1.44</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.mortbay.jasper</groupId>
- <artifactId>apache-el</artifactId>
- <version>10.1.43</version>
+ <artifactId>mortbay-apache-el</artifactId>
+ <version>10.1.44</version>
Review Comment:
Since this is in `dependencyManagement`, changing the coordinates means the
override will not apply to older versions. Do you know if all corresponding
references use the new coordinates?
##########
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/validation/StandardSchemaValidator.java:
##########
@@ -46,6 +47,8 @@ public void validate(final Schema schema, final Source
source) {
try {
validator.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
ProcessingFeature.SECURE_PROCESSING.isEnabled());
+ validator.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, "");
+ validator.setProperty(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");
Review Comment:
For consistency, the `ProcessingAttribute` enumeration includes references
to these named properties, along with expected values, can you make the
adjustments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
