[ 
https://issues.apache.org/jira/browse/NIFI-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard reopened NIFI-14985:
-----------------------------------

The implemented logic is not correct when it comes to checking if we may be in 
the case of a dynamic property being removed. Checking the property descriptor 
is not the right solution because it will always be showing as dynamic: this is 
the default behavior of NiFi when a property is removed, NiFi will keep the 
property and convert it as a dynamic one by default. We should only rely on the 
annotations on the component to check if we're indeed facing a change where the 
property being removed was a static property and its removal should be ignored 
and not showing as a local change.

> Removed property should be considered as an environmental change
> ----------------------------------------------------------------
>
>                 Key: NIFI-14985
>                 URL: https://issues.apache.org/jira/browse/NIFI-14985
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Major
>             Fix For: 2.6.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Let's consider the scenario:
>  * I have a processor version X which is configured with properties A, B, C
>  * I have a versioned flow V that contains this processor version X
>  * Then I create a version Y of the processor where I now only have 
> properties A and B and I did implement the _removeProperty()_ call
> If I import the flow when only the processor version Y is available, the 
> versioned process group will show a local change with the property being 
> removed. We should not show this as a local change since it's an expected 
> modification of the flow with the call of removeProperty() (we should however 
> check that this is not a dynamic property).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to