lordgamez commented on PR #2031: URL: https://github.com/apache/nifi-minifi-cpp/pull/2031#issuecomment-3312194472
> Why make it optional? It doesn't cost much to repackage the binaries in rpm too, especially since rocky is already rpm-based, so it has the tools available. If someone doesn't want it, they can just ignore or delete the rpm package. It actually can have a large impact on the compilation. When I was building the binaries including all extensions, after the tar.gz package build finished it started building the rpm package. For this it rerun the configuration phase and some thirdparty libraries' configuration was also rerun which in some cases, like the grpc or the aws extension, regenerated some files that resulted in the recompilation of those thirdparty libraries. In case of for example the grpc library that compilation took quite a lot of time. Additionally for some reason at the end the rpm package creation failed which made the whole docker build process fail, so neither the rpm package nor the tar.gz was generated at the end. In this scenario it would be beneficial to ignore the rpm package creation altogether when it is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
