martinzink commented on code in PR #2026:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2026#discussion_r2336420866
##########
CMakeLists.txt:
##########
@@ -673,7 +673,28 @@ else()
if (MINIFI_PACKAGING_TYPE STREQUAL "RPM")
set(CPACK_GENERATOR "RPM")
set(CPACK_BINARY_RPM, "ON")
+
set(CPACK_RPM_PACKAGE_NAME "nifi-minifi-cpp")
+ set(CPACK_RPM_PACKAGE_VERSION ${PROJECT_VERSION})
+ set(CPACK_RPM_PACKAGE_RELEASE )
Review Comment:
nope, fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/2026/commits/efe0652d89a22138b5b7380de3f578c50c834a16
I toyed with the idea, the purpose would be to include the
[BUILD_NUMBER](https://github.com/apache/nifi-minifi-cpp/blob/efe0652d89a22138b5b7380de3f578c50c834a16/CMakeLists.txt#L32)
here but we dont usually fill that out during our releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
