szaszm commented on code in PR #2029: URL: https://github.com/apache/nifi-minifi-cpp/pull/2029#discussion_r2371999120
########## extensions/sftp/processors/ListSFTP.cpp: ########## @@ -690,7 +690,7 @@ void ListSFTP::listByTrackingEntities( time_t now = time(nullptr); uint64_t min_timestamp_to_list = (!initial_listing_complete_ && entity_tracking_initial_listing_target_ == ENTITY_TRACKING_INITIAL_LISTING_TARGET_ALL_AVAILABLE) - ? 0U : (now * 1000 - entity_tracking_time_window.count()); + ? 0U : ((now * 1000) - entity_tracking_time_window.count()); Review Comment: I didn't realize this was another clang-tidy check. Yes, please disable it. Putting parens around everything makes no sense, precedence is a well known and useful thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
