Pierre Villard created NIFI-15010:
-------------------------------------

             Summary: FlowDifferenceFilters - better handle property renaming
                 Key: NIFI-15010
                 URL: https://issues.apache.org/jira/browse/NIFI-15010
             Project: Apache NiFi
          Issue Type: Improvement
            Reporter: Pierre Villard
            Assignee: Pierre Villard


Here is a scenario where we are showing local changes when we should not:

Version N of the processor:
{code:java}
    static final PropertyDescriptor BOX_CLIENT_SERVICE = new 
PropertyDescriptor.Builder()
            .name("box-client-service")
            .displayName("Box Client Service")
            .description("Controller Service used to obtain a Box API 
connection.")
            .identifiesControllerService(BoxClientService.class)
            .required(true)
            .build();{code}
Version N+1 of the processor:
{code:java}
    static final PropertyDescriptor BOX_CLIENT_SERVICE = new 
PropertyDescriptor.Builder()
            .name("Box Client Service")
            .description("Controller Service used to obtain a Box API 
connection.")
            .identifiesControllerService(BoxClientService.class)
            .required(true)
            .build();{code}
I'm importing a versioned flow definition that contains:
{code:java}
...
{
          "autoTerminatedRelationships" : [ ],
          "backoffMechanism" : "PENALIZE_FLOWFILE",
          "bulletinLevel" : "WARN",
          "bundle" : {
            "artifact" : "nifi-box-nar",
            "group" : "org.apache.nifi",
            "version" : "2.6.0"
          },
          "comments" : "",
          "componentType" : "PROCESSOR",
          "concurrentlySchedulableTaskCount" : 1,
          "executionNode" : "ALL",
          "groupIdentifier" : "d40a9202-0196-1000-81d1-b5bd440efefc",
          "identifier" : "d40a9205-0196-1000-6e5a-0ac7e98f9862",
          "maxBackoffPeriod" : "10 mins",
          "name" : "Fetch Box File",
          "penaltyDuration" : "3 sec",
          "position" : {
            "x" : -392.0,
            "y" : -56.0
          },
          "properties" : {
            "box-client-service" : "9b205c9a-d9d7-3b25-bbb4-42a07c615258",
            "box-file-id" : "${box.id}"
          },
          "propertyDescriptors" : {
            "box-client-service" : {
              "displayName" : "Box Client Service",
              "dynamic" : false,
              "identifiesControllerService" : true,
              "name" : "box-client-service",
              "sensitive" : false
            },
            "box-file-id" : {
              "displayName" : "File ID",
              "dynamic" : false,
              "identifiesControllerService" : false,
              "name" : "box-file-id",
              "sensitive" : false
            }
          },
          "retriedRelationships" : [ ],
          "retryCount" : 10,
          "runDurationMillis" : 0,
          "scheduledState" : "ENABLED",
          "schedulingPeriod" : "0 sec",
          "schedulingStrategy" : "TIMER_DRIVEN",
          "style" : { },
          "type" : "org.apache.nifi.processors.box.FetchBoxFile",
          "yieldDuration" : "1 sec"
        }
...{code}

When importing the flow, it will show a local change:
*Fetch Box File - Property Added - Property 'Box Client Service' was added*

We should improve the filtering to not show this change as a local change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to