mosermw commented on PR #10372: URL: https://github.com/apache/nifi/pull/10372#issuecomment-3362326306
Sorry, I didn't do any profiling of InvokeHTTP or other NiFi code (there is a change in the PR that looks like would help PutElasticsearchRecord). I did profile my own code, mainly by using Java FlightRecorder to capture a million iterations of a unit test. Those results would always show fewer garbage collections occurred after these changes, indicating less garbage generated. Exactly how much this would affect GC in NiFi overall depends on lots of things. Taking this PR on its own, GC improvements might not even be noticeable. In NiFi overall, we found the most noticeable GC savings comes from using the `-XX:+UseStringDeduplication` flag in G1, which perhaps is making FlowFile attribute storage more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
