exceptionfactory commented on code in PR #10398:
URL: https://github.com/apache/nifi/pull/10398#discussion_r2413984347
##########
nifi-extension-bundles/nifi-hashicorp-vault-bundle/nifi-hashicorp-vault-client-service-api/src/main/java/org/apache/nifi/vault/hashicorp/HashiCorpVaultClientService.java:
##########
@@ -37,17 +38,15 @@ public interface HashiCorpVaultClientService extends
ControllerService, Verifiab
"Use one or more '.properties' files to configure the client");
PropertyDescriptor CONFIGURATION_STRATEGY = new
PropertyDescriptor.Builder()
- .displayName("Configuration Strategy")
- .name("configuration-strategy")
+ .name("Configuration Strategy")
.required(true)
.allowableValues(DIRECT_PROPERTIES, PROPERTIES_FILES)
.defaultValue(DIRECT_PROPERTIES.getValue())
.description("Specifies the source of the configuration
properties.")
.build();
PropertyDescriptor VAULT_URI = new PropertyDescriptor.Builder()
- .name("vault.uri")
- .displayName("Vault URI")
+ .name("Vault URI")
Review Comment:
In this particular case, the property names align to the underlying library,
so this particular class should remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
