pvillard31 opened a new pull request, #10340:
URL: https://github.com/apache/nifi/pull/10340
# Summary
NIFI-15010 - FlowDifferenceFilters - better handle property renaming
Here is a scenario where we are showing local changes when we should not:
Version N of the processor:
````java
static final PropertyDescriptor BOX_CLIENT_SERVICE = new
PropertyDescriptor.Builder()
.name("box-client-service")
.displayName("Box Client Service")
.description("Controller Service used to obtain a Box API
connection.")
.identifiesControllerService(BoxClientService.class)
.required(true)
.build();
````
Version N+1 of the processor:
````java
static final PropertyDescriptor BOX_CLIENT_SERVICE = new
PropertyDescriptor.Builder()
.name("Box Client Service")
.description("Controller Service used to obtain a Box API
connection.")
.identifiesControllerService(BoxClientService.class)
.required(true)
.build();
````
I'm importing a versioned flow definition that contains:
````json
...
{
"autoTerminatedRelationships" : [ ],
"backoffMechanism" : "PENALIZE_FLOWFILE",
"bulletinLevel" : "WARN",
"bundle" : {
"artifact" : "nifi-box-nar",
"group" : "org.apache.nifi",
"version" : "2.6.0"
},
"comments" : "",
"componentType" : "PROCESSOR",
"concurrentlySchedulableTaskCount" : 1,
"executionNode" : "ALL",
"groupIdentifier" : "d40a9202-0196-1000-81d1-b5bd440efefc",
"identifier" : "d40a9205-0196-1000-6e5a-0ac7e98f9862",
"maxBackoffPeriod" : "10 mins",
"name" : "Fetch Box File",
"penaltyDuration" : "3 sec",
"position" : {
"x" : -392.0,
"y" : -56.0
},
"properties" : {
"box-client-service" : "9b205c9a-d9d7-3b25-bbb4-42a07c615258",
"box-file-id" : "${box.id}"
},
"propertyDescriptors" : {
"box-client-service" : {
"displayName" : "Box Client Service",
"dynamic" : false,
"identifiesControllerService" : true,
"name" : "box-client-service",
"sensitive" : false
},
"box-file-id" : {
"displayName" : "File ID",
"dynamic" : false,
"identifiesControllerService" : false,
"name" : "box-file-id",
"sensitive" : false
}
},
"retriedRelationships" : [ ],
"retryCount" : 10,
"runDurationMillis" : 0,
"scheduledState" : "ENABLED",
"schedulingPeriod" : "0 sec",
"schedulingStrategy" : "TIMER_DRIVEN",
"style" : { },
"type" : "org.apache.nifi.processors.box.FetchBoxFile",
"yieldDuration" : "1 sec"
}
...
````
When importing the flow, it will show a local change:
Fetch Box File - Property Added - Property 'Box Client Service' was added
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
