mattyb149 commented on code in PR #10455:
URL: https://github.com/apache/nifi/pull/10455#discussion_r2461023021
##########
nifi-extension-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java:
##########
@@ -138,6 +143,8 @@ public class ExecuteGroovyScript extends AbstractProcessor {
public static final Relationship REL_FAILURE = new
Relationship.Builder().name("failure").description("FlowFiles that failed to be
processed").build();
+ public static final int VALIDATION_TIMEOUT_MINUTES = 5;
Review Comment:
5 minutes seems excessive, for Grabs from the internet I would think 1 or 2
minutes should suffice, but if this is more of a "safety valve" thing to
prevent infinite waiting then I'm ok with 5 minutes, just thinking the user
might think it's hanging indefinitely after a couple of minutes. Probably could
use some documentation of this timeout in the Additional Details when using
@Grab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
