ravinarayansingh commented on PR #10405: URL: https://github.com/apache/nifi/pull/10405#issuecomment-3474463573
> Thanks for the updates @ravinarayansingh. > > It looks like the changes resulted in some unit test failures: > > ``` > TestFTP.testFetchFtpUnicodeFileName:350 expected: <1> but was: <0> > TestFTP.testFetchFtp:257 ยป IndexOutOfBounds Index 0 out of bounds for length 0 > ``` > > I should have considered this in my previous reply, but the changes surface the fact that the `FetchFTP` and `FetchSFTP` Processors do not have `failure` and `reject` relationships. They have more specific types of failure relationships, (not found, permission denied, and comms failure), but those do not immediately align with the other failure conditions. > > Introducing new relationships creates potential migration problems if not handled programmatically, such as auto-terminating or migrating. That could be done, but on balance, adding new relationships seems to introduce additional complexity for a conditional scenario, which is not ideal. > > Taking another look at the options, I think the `reject` and `fail` completion strategies should be removed and not supported in this Processor. Instead, limiting support to `ignore` or `rename` would avoid introducing new relationships, and still provide more flexibility. > > How does that sound? Hi @exceptionfactory That makes perfect sense, I agree with you. Limiting the completion strategies to ignore and rename sounds like the right approach. It keeps the design simpler and avoids unnecessary migration or compatibility issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
