szaszm commented on code in PR #2076:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2076#discussion_r2543003161
##########
libminifi/src/core/ProcessSession.cpp:
##########
@@ -1038,10 +1038,12 @@ void ProcessSessionImpl::persistFlowFilesBeforeTransfer(
std::map<Connectable*, std::vector<std::shared_ptr<core::FlowFile> > >&
transactionMap,
const std::map<utils::Identifier, FlowFileUpdate>& modifiedFlowFiles) {
- std::vector<std::pair<std::string, std::unique_ptr<io::BufferStream>>>
flowData;
-
auto flowFileRepo = process_context_->getFlowFileRepository();
- auto contentRepo = process_context_->getContentRepository();
+ if (flowFileRepo->isNoop()) {
+ return;
+ }
Review Comment:
I think an explanation would be useful in a code comment explaining why we
avoid doing all of this when the flow file repo is noop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
