mcgilman commented on code in PR #10583:
URL: https://github.com/apache/nifi/pull/10583#discussion_r2579207692
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/users/service/users.service.ts:
##########
@@ -73,7 +71,7 @@ export class UsersService {
...request.userPayload
}
};
- return this.httpClient.put(this.nifiCommon.stripProtocol(request.uri),
payload);
+ return
this.httpClient.put(`${UsersService.API}/tenants/users/${request.id}`, payload);
Review Comment:
I believe the `uri` field in the `request` object is no longer used and can
be removed.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/queue.service.ts:
##########
@@ -42,11 +40,15 @@ export class QueueService {
);
}
- pollEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.get(this.nifiCommon.stripProtocol(dropRequest.uri));
+ pollEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.get(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
}
- deleteEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.delete(this.nifiCommon.stripProtocol(dropRequest.uri));
+ deleteEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.delete(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
Review Comment:
This delete method only works for clearing single queues. When clearing
multiple queues (through the Empty All Queues menu item on a Process Group) we
don't have a single connection id. Rather we have a single Process Group id
like in the submit method above.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/queue.service.ts:
##########
@@ -42,11 +40,15 @@ export class QueueService {
);
}
- pollEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.get(this.nifiCommon.stripProtocol(dropRequest.uri));
+ pollEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.get(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
Review Comment:
This poll method only works for clearing single queues. When clearing
multiple queues (through the Empty All Queues menu item on a Process Group) we
don't have a single connection id. Rather we have a single Process Group id
like in the submit method above.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/users/service/users.service.ts:
##########
@@ -85,7 +83,7 @@ export class UsersService {
...request.userGroupPayload
}
};
- return this.httpClient.put(this.nifiCommon.stripProtocol(request.uri),
payload);
+ return
this.httpClient.put(`${UsersService.API}/tenants/user-groups/${request.id}`,
payload);
Review Comment:
I believe the `uri` field in the `request` object is no longer used and can
be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
